Repository navigation
ci: automate signed catalog releases - #314
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. What this changesThis PR adds a shared signed-tag release workflow, release-version metadata, and instructions for automated source publication. Example: Dispatch release.yml on main with version=0.5.0 and dry_run=true.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 4 items remain Keep this maintainer-authored PR open: automating verified source releases has clear value, and current main still uses manual publication; correct the documented retry behavior. Priority: P2 Before merge
Findings
Tests
Agent review detailsHow this fits togetherThe catalog release caller sends version, signing, CI, and validation requirements to the shared release workflow, which produces verified source archives and publishes GitHub Releases. flowchart TD
A[Signed tag or manual dispatch] --> B[Catalog release caller]
B --> C[Protected source and CI validation]
C --> D[Catalog checks and source archives]
D --> E[Independent artifact verification]
E --> F[GitHub Release publication]
Technical reviewBest possible solution: Retain the thin shared-workflow caller with accurate retry documentation and verified publication authorization. Do we have a high-confidence way to reproduce the issue? The retry documentation mismatch is source-reproducible: the selected publisher explicitly resumes matching drafts and accepts identical public releases; no target code was executed. Is this the best way to solve the issue? A thin caller is appropriate because the shared workflow already owns signing checks, artifact verification, and publication; duplicating those controls locally would create another release owner. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 77b229e42b40. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: none. SecurityNeeds attention: The publication controls are present in source, but their final-effect authorization boundary remains unverified. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 12, 2026, 12:14 AM ET / 04:14 UTC. |
Use the shared source release workflow at
@v1for the skill catalog. Add explicit release-version metadata and an SSH tag signer policy; require protected-main ancestry, dated changelog notes, and green exact-commit push CI. Publish verified commit source archives with checksums through Actions.Replace the manual publication instructions with signed-tag releases and default no-publish dispatches. No npm package, version tag, or release is created by this change.
Validation: catalog frontmatter validation, actionlint, whitespace checks, and independent Codex review passed. The existing Linux, Windows, and native macOS CI remains the full source gate. A no-publish dispatch will exercise merged main.